Minor coverages improvements#2373
Conversation
pvgenuchten
left a comment
pvgenuchten
left a comment
There was a problem hiding this comment.
thanx @webb-ben, changes are usefull
let's discuss in timisuara how we can best improve the link display for a next PR
@tomkralidis can we release before foss4g-eu? a change like this would be usefull for the training
|
We will be releasing 0.24 after FOSS4G-EU. |
|
|
||
| content = render_j2_template(api.tpl_config, tpl_config, | ||
| 'collections/coverages/coverage.html', | ||
| 'collections/coverages/index.html', |
There was a problem hiding this comment.
collections/coverage/index.html (and rename actual template file).
|
Thanx @webb-ben and @tomkralidis, useful discussion and great work! |
|
the .../coverage page is nice with the coverage view, but it looks a bit empty, maybe good to repeat the title/abstract/keywords of the coverage here. The difference with the /collections/grid request page is minimal then, but should be ok. the json and json-ld links in the top right, can we extend it to include the cov-json and grib formats? (json-ld should probably be removed, because clicking it throws invalidparamvalue, it is also used to embed schema.org on the page, this should probably also be removed, not sure if easy to remove, because this comes from inherited templates) |
|
The coverage HTML is a near direct copy of the EDR HTML in which the JSON-LD does not work either. I'd be interested to also return the links for these in the CovJSON (related to opengeospatial/ogcapi-environmental-data-retrieval#666) Out of scope for this PR for sure and not sure how actually helpful it is, but there is https://covjson.org/context.jsonld |
4 participants
Overview
Based on #2370, introduce minor coverage improvements:
/collections/{cid}. This is a shallow copy of the EDR HTML template with small modifications. The HTML is served from browsers with default accept headersRelated Issue / discussion
#2370
Additional information
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)